feat: rewrite joins + refactoring + adding missing join-file#24
Merged
SemyonSinchenko merged 2 commits intomainfrom Feb 24, 2025
Merged
feat: rewrite joins + refactoring + adding missing join-file#24SemyonSinchenko merged 2 commits intomainfrom
SemyonSinchenko merged 2 commits intomainfrom
Conversation
|
Thank you @SemyonSinchenko ! |
Collaborator
Author
|
I cannot reach @MrPowers. Theoretically, I can bypass branch protection and merge. @zhuqi-lucas how urgent is this for you? |
|
Thank you @SemyonSinchenko for your work, i also think we can merge it, and i can try it in apache datafusion as a follow-up, and if we meet new errors, we can push another fix, do you think so? |
Collaborator
Author
|
@zhuqi-lucas Merged & Released to PyPI (0.0.3). Feel free to ping me in case of any issues! |
This was referenced Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #21
It looks like it works:

Changes:
I tried SMALL and MEDIUM generations only, I don't think that my laptop is able to handle generation of BIG.
I'm trying to realize how keys manipulation can be faster on the python side.
@MrPowers Could you please try it? I'm not very familiar with this benchmark queries, I just tried one. Anyway you are the only person who can approve it ;)
@zhuqi-lucas cc