Repository navigation
Fix UTF-8 char boundary panic in snippet_from_doc - #6
Merged
Merged
Conversation
snippet_from_doc computed byte offsets (pos - 40, pos + len + 80) from a lowercase match and sliced the document body directly. Those offsets can land inside a multi-byte UTF-8 character, causing a slice-index panic on documents containing non-ASCII text. Snap both the start and end offsets to the nearest character boundary and guard against a reversed range. Add regression tests covering multibyte bodies for the match, offset-shifted match, and no-match fallback paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
okf searchpanicked on documents containing non-ASCII text:snippet_from_doccomputed byte offsets (pos - 40,pos + len + 80) from a lowercase match on the document body and slicedbodydirectly. Those offsets can land inside a multi-byte UTF-8 character, and Rust panics when slicing at a non-char-boundary index.Fix
floor_char_boundary/ceil_char_boundaryhelpers that snap an arbitrary byte index to the nearest UTF-8 character boundary.snippet_from_docnow snaps bothstartandend, and guards against a reversed range.Verification
cargo fmt,cargo clippy --all-targets, andcargo testall pass.