Skip to content

🐞 Fix crash when a cycle action has an empty cycle #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bit-saver wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

🐞 Fix crash when a cycle action has an empty cycle #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Loop/Core/LoopManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,10 @@ extension LoopManager {
}

private func getNextCycleAction(_ action: WindowAction) async -> WindowAction {
guard let currentCycle = action.cycle else {
// An empty cycle has no actions to advance to; bail out instead of indexing
// into it — the `currentCycle[0]` accesses below would trap on an empty array
// (EXC_BREAKPOINT crash when a cycle action is configured with no sub-actions).

@mrkai77 mrkai77 Jul 2, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a bit too verbose. It’s definitely a bug, but I think it’s already fairly clear what !currentCycle.isEmpty is trying to fix here.

guard let currentCycle = action.cycle, !currentCycle.isEmpty else {
return action
}

Expand Down