Skip to content

Add a guard clause to verb _parse #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hovatterz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a guard clause to verb _parse #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f36b441
Add a guard clause to verb _parse
hovatterz Aug 15, 2025
1f0a4f7
Remove try/catch since None is handled with guard clause
hovatterz Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/mud_parser/verb/verb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ def _parse(self, message: Union[Tuple[str], str]) -> str:
"""
import logging

try:
if isinstance(message, tuple):
return b"\r\n".join([m.encode("utf-8") for m in message])
return message.encode("utf-8")
except AttributeError as e:
logging.debug(e)
# Early bailout if there is no message
Comment thread
mrjeckel marked this conversation as resolved.
if message == None:
return None

if isinstance(message, tuple):
return b"\r\n".join([m.encode("utf-8") for m in message])
return message.encode("utf-8")