Skip to content

feat(verify-pr): add file-type scoping to convention upgrades #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ruromero wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(verify-pr): add file-type scoping to convention upgrades #144

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24824ed
feat(verify-pr): add file-type scoping to convention upgrades
ruromero May 29, 2026
3b0f8d7
fix(verify-pr): add CONVENTIONS.md fixture to eval 3 for applicabilit…
ruromero May 29, 2026
4fcbfc2
fix(verify-pr): revert out-of-scope eval fixture and assertions
ruromero May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions plugins/sdlc-workflow/skills/verify-pr/style-conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ documented conventions that match the suggested practice. For example, if the
reviewer suggests adding indexes for foreign key columns, check whether
CONVENTIONS.md documents index creation patterns.

After finding a matching convention, verify that the convention's file-type scope
overlaps with the PR's changed files, following the rules in
`shared/convention-applicability-rules.md`. Extract the PR's changed file types
from the diff headers (`--- a/path` and `+++ b/path` lines) in the PR Diff input.
If the convention's file-type scope does not overlap with any of the PR's changed
files, discard the convention match — do not use it for upgrade purposes.
Conventions without explicit file-type scope are treated as broadly applicable
(no filtering).

If CONVENTIONS.md is not provided (empty or absent), skip this sub-step.

#### 1b — Check Codebase Patterns
Expand All @@ -59,11 +68,12 @@ index migrations, caching layers, documented performance conventions).

#### 1d — Upgrade Decision

If the suggestion matches a documented convention in CONVENTIONS.md **or** is
demonstrated by consistent codebase usage (multiple instances of the same pattern
in similar files), upgrade the classification from **suggestion** to **code change
request**. Record the evidence:
- `"Matches documented convention: [CONVENTIONS.md section or quote]"`
If the suggestion matches a documented convention in CONVENTIONS.md (and passes
the file-type applicability check from 1a) **or** is demonstrated by consistent
codebase usage (multiple instances of the same pattern in similar files), upgrade
the classification from **suggestion** to **code change request**. Record the
evidence:
- `"Matches documented convention: [CONVENTIONS.md section or quote] — Applicable: [yes, file types: <convention scope> match PR's changed <file types>]"`
- `"Matches codebase convention: [N occurrences of pattern in similar files]"`

Suggestions that do not match any documented or demonstrated convention remain
Expand Down
Loading