-
Notifications
You must be signed in to change notification settings - Fork 3
Migrate eval engine to skill-litmus #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mrizzi
wants to merge
7
commits into
main
Choose a base branch
from
worktree-adopt-skill-litmus
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9641a2e
chore(evals): add plugin field to all evals.json files
mrizzi 3578e4e
ci: replace eval workflows with skill-litmus action
mrizzi 5190b19
refactor: remove run-evals skill from sdlc-workflow
mrizzi 5665efb
docs: update eval references from sdlc-workflow to skill-litmus
mrizzi 0df540f
ci: bump skill-litmus action to v0.1.3
mrizzi e971531
ci: bump skill-litmus action to v0.1.4
mrizzi f0d16b9
ci: bump skill-litmus action to v0.1.5
mrizzi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| name: Skill Evals | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'plugins/sdlc-workflow/skills/**/*.md' | ||
| - 'evals/**/evals.json' | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'plugins/sdlc-workflow/skills/**/*.md' | ||
| - 'evals/**/evals.json' | ||
|
|
||
| jobs: | ||
| eval: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
|
|
||
| - uses: google-github-actions/auth@v3 | ||
| with: | ||
| credentials_json: ${{ secrets.GCP_SA_KEY }} | ||
|
|
||
| - uses: mrizzi/skill-litmus@v0.1.5 | ||
| env: | ||
| CLAUDE_CODE_USE_VERTEX: "1" | ||
| CLOUD_ML_REGION: ${{ secrets.GCP_CLOUD_ML_REGION }} | ||
| ANTHROPIC_DEFAULT_SONNET_MODEL: "claude-sonnet-4-6" | ||
| ANTHROPIC_DEFAULT_OPUS_MODEL: "claude-opus-4-6" | ||
| ANTHROPIC_MODEL: "claude-opus-4-6" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): Workflow will not have access to
secrets.GCP_SA_KEYorpull-requests: writepermissions for PRs from forks, likely breaking evals for external contributions.For PRs from forks, this job won’t be able to use
GCP_SA_KEYorpull-requests: write, so evals will fail or be skipped for external contributors.To support forked PRs, consider either:
pull_request_targetonly for the secret/commenting step, with a hardened checkout (e.g.,ref: ${{ github.event.pull_request.head.sha }}and restricted paths), orpull_requestwithout secrets, and apull_request_targetjob that just posts results using secrets.Otherwise, external contributors will have a worse experience than maintainers’ branches.