command: prevent fall back to global usage for subcommand option errors#76
Open
HoyeonRhee wants to merge 1 commit into
Open
command: prevent fall back to global usage for subcommand option errors#76HoyeonRhee wants to merge 1 commit into
HoyeonRhee wants to merge 1 commit into
Conversation
Argparse reports unknown arguments from top-level parser even after selecting a subcommand, so command like "b4 dig --unknown-arg" prints the global usage instead of the dig usage. To handle, this commit set a subparser attribute for each subcommand parser, then use parse_known_args() in cmd() to report leftover arguments from the selected subparser instead of the top-level parser. Signed-off-by: Hoyeon Lee <hoyeon.lee@suse.com>
256de77 to
9535898
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argparse reports unknown arguments from top-level parser even after
selecting a subcommand, so command like "b4 dig --unknown-arg" prints
the global usage instead of the dig usage.
To handle, this commit set a subparser attribute for each subcommand
parser, then use parse_known_args() in cmd() to report leftover arguments
from the selected subparser instead of the top-level parser.
Fixes: #75