add absorption examples#1
Open
vjd wants to merge 4 commits intomrgsolve:masterfrom
Open
Conversation
mixed zero and first order absorption
kylebaron
reviewed
Dec 12, 2017
kylebaron
left a comment
kylebaron
left a comment
There was a problem hiding this comment.
@vjd Do you mind updating examples so compartments aren't listed in $CAPTURE ? Also, I'd like to encourage using capture typedef in $TABLE. Would you mind changing that too?
I don't want to enforce a style guide or anything like that, but I'd like to request that vignettes utilize certain features just so that these features get into the examples and hopefully get used more.
| $TABLE | ||
| double CP = CENT/VC; | ||
|
|
||
| $CAPTURE CP GUT CENT |
| dxdt_CENT = KA*GUT - (CL/VC)*CENT; | ||
|
|
||
| $TABLE | ||
| double CP = CENT/VC; |
| dxdt_CENT = KA*GUT - (CL/VC)*CENT; | ||
|
|
||
| $TABLE | ||
| double CP = CENT/VC; |
There was a problem hiding this comment.
... and similar comment for other examples too.
| $TABLE | ||
| double CP = CENT/VC; | ||
|
|
||
| $CAPTURE CP GUT CENT |
There was a problem hiding this comment.
... same comment for other examples too.
kylebaron
requested changes
Dec 15, 2017
| double GAMA1 = GAMA; | ||
|
|
||
| // Weibull function | ||
| double WB = 1 - exp(pow((-KA*TIME),GAMA1)); |
There was a problem hiding this comment.
@vjd move the minus sign?
`double WB = 1 - exp(-pow((KA*TIME),GAMA));``
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two examples -