refactor: Clean up and enhance bot configuration and error handling#31
refactor: Clean up and enhance bot configuration and error handling#31mrMigles wants to merge 1 commit into
Conversation
- Removed unused proxy configuration and related code from BotConfiguration. - Updated error handling in MongoDataHelper and EducationCache to log exceptions. - Introduced ChatAdminService for managing chat administrators, improving code reuse. - Refactored TelegramBot to use ExecutorService for better thread management. - Enhanced inline query handling with timeout management. - Removed deprecated UserAccessInfo class and related methods. - Updated various processors to utilize ChatAdminService for admin checks. - Improved request handling with URL validation in Request class. This commit streamlines the bot's configuration and enhances error handling across multiple components.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8906d4fba4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| database: ${DATABASE:localhost} | ||
| password: ${PASSWORD:password} | ||
| database: ${DATABASE:botplatform} | ||
| password: ${PASSWORD} |
There was a problem hiding this comment.
When PASSWORD is not defined, this unresolved ${PASSWORD} placeholder is used while binding Spring Boot MongoDB properties and the application fails during startup before it can use the documented defaults around it. The previous config provided a fallback, so any local/CI/deployment environment that relied on the default password (or simply omitted a Mongo password) now cannot boot; use an empty/default placeholder such as the other secrets do if the value is optional.
Useful? React with 👍 / 👎.
1 participant
This commit streamlines the bot's configuration and enhances error handling across multiple components.