fix: read 64-bit mpv INT64 properties without truncating to 32 bits - #776
Open
Bolt4243 wants to merge 1 commit into
Open
fix: read 64-bit mpv INT64 properties without truncating to 32 bits#776Bolt4243 wants to merge 1 commit into
Bolt4243 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two places read an MPV_FORMAT_INT64 property as 32 bits:
GetPropertyInt: returns lpBuffer.ToInt32(), silently truncating values above 2 GB. GetPropertyLong on the same pointer correctly uses ToInt64(). Fix: return (int)lpBuffer.ToInt64().
OnPropertyChange INT64 branch: uses Marshal.PtrToStructure(data.data), reading only 4 of the 8 bytes mpv wrote. Fix: use Marshal.PtrToStructure(data.data) and narrow to int.