Skip to content

Honor catalog-declared model setting choices - #709

Open
breedx wants to merge 1 commit into
mpfaffenberger:mainfrom
breedx:feat/catalog-setting-choices-upstream
Open

Honor catalog-declared model setting choices#709
breedx wants to merge 1 commit into
mpfaffenberger:mainfrom
breedx:feat/catalog-setting-choices-upstream

Conversation

@breedx

@breedx breedx commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • prefer a model catalog's setting_choices for choice-based settings
  • retain the existing reasoning capability flags as the fallback
  • ignore unknown advertised values by intersecting with client-supported choices

This lets remotely discovered models expose valid levels such as xhigh without hardcoding model IDs.

Verification

  • pytest -q --no-cov tests/command_line/test_model_settings_menu_coverage.py — 93 passed
  • Ruff check and format clean for the two changed files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant