Keep model catalog loads out of settings TUI repaints - #703
Open
breedx wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/model_settingssessionmodel_supports_settingaccept an optional preloaded catalogReproduction
The model picker called
ModelFactory.load_config()16 times per repaint: once in the list and 15 times while deriving capabilities for the details panel. For network-backed model catalogs, a 0.9s config load made each arrow/Enter/Esc repaint take 14.89s. The inner settings view remained responsive because it reused its supported-settings list.Verification
TypeErrorpropagation is covered (no exception-driven retry)