fix(http/response): Don't write body on HEAD request - #34
Merged
Merged
Conversation
added 2 commits
April 17, 2026 16:59
RFC 9110 8.6 contains the following paragraph: "A server MAY send a Content-Length header field in a response to a HEAD request (Section 9.3.2); a server MUST NOT send Content-Length in such a response unless its field value equals the decimal number of octets that would have been sent in the content of a response if the same request had used the GET method." When writing a nil body and closing the output stream, Helidon recomputes the length of the body bytes and overwrites any content-length header provided. In the case of a HEAD request, where a content-length header may be provided but where there is no body, this causes the content-length to be reset to 0. This commit adds a special set-head-response! function that avoids writing the body, and calls send() on the server-response instead, as required by Helidon, see https://helidon.io/docs/v4/se/webserver/webserver#anchor-sending-response
Owner
|
Thanks! |
Owner
|
It's on clojars as 1.0.0-alpha213 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 9110 8.6 contains the following paragraph:
"A server MAY send a Content-Length header field in a response to a HEAD request (Section 9.3.2); a server MUST NOT send Content-Length in such a response unless its field value equals the decimal number of octets that would have been sent in the content of a response if the same request had used the GET method."
When writing a nil body and closing the output stream, Helidon recomputes the length of the body bytes and overwrites any content-length header provided. In the case of a HEAD request, where a content-length header may be provided but where there is no body, this causes the content-length to be reset to 0.
This commit adds a special set-head-response! function that avoids writing the body, and calls send() on the server-response instead, as required by Helidon, see
https://helidon.io/docs/v4/se/webserver/webserver#anchor-sending-response
Fixes #33