Conversation
Introduce Helidon gRPC integration: add s-exp.hirundo.grpc.routing and s-exp.hirundo.grpc.service implementations, wire :grpc-services server option, and require grpc routing in the main namespace. Update deps.edn (helidon-webserver-grpc and grpc-netty-shaded for tests). Add test proto, generated Java classes and comprehensive gRPC tests.
Add a tools.build task and deps alias to compile Java test sources (test/java -> test/classes) and invoke it in the GitHub Actions test workflow before running Clojure tests.
Add s-exp.hirundo.grpc with send!, complete! and error! wrappers for io.grpc.stub.StreamObserver. Update README with a gRPC section and examples, and adjust tests to use the new helpers and require the grpc namespace.
Provide a function that builds a Java StreamObserver from optional :on-next, :on-error and :on-completed callbacks. Update README and tests to use the helper, simplifying bidi handler implementations
mpenet
marked this pull request as ready for review
March 15, 2026 17:00
Introduce unary-async-handler, server-stream-async-handler, client-stream-async-handler and bidi-async-handler that expose core.async channels for request/response streaming. Handlers support configurable channel factories (:in-ch-fn, :out-ch-fn). Update README with usage examples and add tests for unary, server-stream and bidi scenarios. Also require clojure.core.async in the grpc namespace and apply minor formatting tweaks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce Helidon gRPC integration: add s-exp.hirundo.grpc.routing and s-exp.hirundo.grpc.service implementations, wire :grpc-services server option, and require grpc routing in the main namespace.