fix: add Win32_Security feature to windows-sys dependency#2627
Merged
sylvestre merged 1 commit intomozilla:mainfrom Mar 5, 2026
Merged
fix: add Win32_Security feature to windows-sys dependency#2627sylvestre merged 1 commit intomozilla:mainfrom
sylvestre merged 1 commit intomozilla:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2627 +/- ##
==========================================
- Coverage 73.40% 73.40% -0.01%
==========================================
Files 68 68
Lines 37219 37219
==========================================
- Hits 27320 27319 -1
- Misses 9899 9900 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JulienCote
force-pushed
the
fix/windows-sys-security-feature
branch
from
a26246a to
4c7a5e3
Compare
CreateProcessW requires the Win32_Security feature because its signature includes SECURITY_ATTRIBUTES. Without this feature, `cargo install sccache` fails on Windows with: error[E0432]: unresolved import `windows_sys::Win32::System::Threading::CreateProcessW` Fixes mozilla#2484 Fixes mozilla#2508
sylvestre
force-pushed
the
fix/windows-sys-security-feature
branch
from
4c7a5e3 to
c43a832
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateProcessW requires the Win32_Security feature because its signature includes SECURITY_ATTRIBUTES. Without this feature,
cargo install sccachefails on Windows with:error[E0432]: unresolved import
windows_sys::Win32::System::Threading::CreateProcessWFixes #2484
Fixes #2508