msvc: Append the default .pdb extension for the /Fd argument#2621
msvc: Append the default .pdb extension for the /Fd argument#2621sylvestre merged 3 commits intomozilla:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
==========================================
- Coverage 73.40% 73.37% -0.03%
==========================================
Files 68 68
Lines 37219 37337 +118
==========================================
+ Hits 27320 27397 +77
- Misses 9899 9940 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing Footnotes
|
|
@ikolomiko, please, recheck the format: looks like it's failed |
|
Oopsies, fixed it |
|
Nice! Can you add the test for that, please? It will help with unexpected regression |
|
@AJIOB sure, here it is! |
|
Looks like the ci pipeline is borked :d |
MSVC appends the .pdb extension for the file path given for the /Fd argument, if the extension is omitted. This commit adds this functionality for feature parity.
MSVC appends the .pdb extension for the file path given for the /Fd argument, if the extension is omitted. This commit adds this functionality for feature parity.
Fixes #2620