Skip to content

msvc: Append the default .pdb extension for the /Fd argument#2621

Merged
sylvestre merged 3 commits intomozilla:mainfrom
ikolomiko:main
Mar 5, 2026
Merged

msvc: Append the default .pdb extension for the /Fd argument#2621
sylvestre merged 3 commits intomozilla:mainfrom
ikolomiko:main

Conversation

@ikolomiko
Copy link
Contributor

MSVC appends the .pdb extension for the file path given for the /Fd argument, if the extension is omitted. This commit adds this functionality for feature parity.

Fixes #2620

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2026

Codecov Report

❌ Patch coverage is 68.00000% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.37%. Comparing base (0efe890) to head (782d55c).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/compiler/msvc.rs 68.00% 40 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2621      +/-   ##
==========================================
- Coverage   73.40%   73.37%   -0.03%     
==========================================
  Files          68       68              
  Lines       37219    37337     +118     
==========================================
+ Hits        27320    27397      +77     
- Misses       9899     9940      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2026

Merging this PR will not alter performance

✅ 60 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing ikolomiko:main (782d55c) with main (0efe890)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AJIOB
Copy link
Contributor

AJIOB commented Feb 21, 2026

@ikolomiko, please, recheck the format: looks like it's failed

@ikolomiko
Copy link
Contributor Author

Oopsies, fixed it

@ikolomiko ikolomiko requested a review from AJIOB March 2, 2026 05:00
@AJIOB
Copy link
Contributor

AJIOB commented Mar 2, 2026

Nice! Can you add the test for that, please?

It will help with unexpected regression

Copy link
Contributor

@AJIOB AJIOB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests, please

@ikolomiko
Copy link
Contributor Author

@AJIOB sure, here it is!

@ikolomiko ikolomiko requested a review from AJIOB March 3, 2026 21:07
@ikolomiko
Copy link
Contributor Author

Looks like the ci pipeline is borked :d

ikolomiko and others added 3 commits March 5, 2026 22:55
MSVC appends the .pdb extension for the file path given for the /Fd argument, if the extension is omitted. This commit adds this functionality for feature parity.
@sylvestre sylvestre merged commit 7b92ba4 into mozilla:main Mar 5, 2026
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sccache fails to find the PDB file given with /Fd when the .pdb file extension is omitted

4 participants