Disable reqwest default features to not depend on openssl#2421
Disable reqwest default features to not depend on openssl#2421tylerhawkes wants to merge 2 commits intomozilla:mainfrom
Conversation
|
sorry but it needs to be rebased |
@sylvestre done |
|
fails with: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
- Coverage 71.22% 67.97% -3.25%
==========================================
Files 64 64
Lines 35214 34723 -491
==========================================
- Hits 25080 23602 -1478
- Misses 10134 11121 +987 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sylvestre I think I have everything downgraded that is incompatible with 1.75 |
|
Turns out updating with an older version requirement is just too hard, especially when I can't test out the windows stuff, so I'm downgrading this to just the one change to remove the default dependencies for reqwest. |
|
@sylvestre I just updated this again. Maybe the tests will pass this time after all the other crate updates. |
…a#2421) ## Motivation This makes [max_local_error_reset_streams](https://docs.rs/hyper/latest/hyper/server/conn/http2/struct.Builder.html#method.max_local_error_reset_streams) configurable. We have an isolated environment where we create and close many (valid) short-lived gRPC streams. We very quickly hit the 1024 limit on stream resets, which [initiates a GoAway](https://doc.servo.org/src/h2/proto/streams/streams.rs.html#1583). During connection recreation, the Python gRPC client misbehaves. We would like the option to tune this limit, since this is a safe traffic pattern for us. ## Solution I've added `http2_max_local_error_reset_streams` to the `Server` API. --------- Co-authored-by: alexanderrilee <alexanderrilee@users.noreply.github.com> Co-authored-by: tottoto <tottotodev@gmail.com>
|
Cargo install currently fails due to github.com/rust-native-tls/rust-native-tls/issues/367. It might be nice to get this merged to avoid such issues in the future (allowing users to switch between native-tls and rustls as they like). |
5 participants
Fixes #841
I also did a cargo update to get the latest dependencies. All the tests were able to build, and I did get a failure locally, but probably due to my setup.