Bug 2022720 Test Version Refactor: Refactor how the expanded row's components are rendered#1016
Open
kala-moz wants to merge 4 commits intomozilla:mainfrom
Open
Bug 2022720 Test Version Refactor: Refactor how the expanded row's components are rendered#1016kala-moz wants to merge 4 commits intomozilla:mainfrom
kala-moz wants to merge 4 commits intomozilla:mainfrom
Conversation
Added new methods to the strategy interface: expanded left, expanded right, expanded bottom, and getComparisonreResult
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
- Coverage 96.46% 96.45% -0.01%
==========================================
Files 109 109
Lines 3051 3050 -1
Branches 691 686 -5
==========================================
- Hits 2943 2942 -1
Misses 107 107
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For bug: https://bugzilla.mozilla.org/show_bug.cgi?id=2022720
This PR continues the test version refactor work by removing the conditionals in
RevisionRowExpandableby extending the methods inTestVersionStrategyto include components rendered in the expanded rows: expanded left, expanded right, expanded bottom, and getComparisonResult.Next, the components specific to the test versions were moved from the
RevisionRowExpandedto the appropriate test version files. For example:Now, RevisionRowExpanded just calls the strategy interface to render the components based on the test version.