Bug-2022758: Remove redundant Dark fonts#1011
Open
moijes12 wants to merge 2 commits intomozilla:mainfrom
Open
Conversation
✅ Deploy Preview for mozilla-perfcompare ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Refactor fonts.ts to remove the redundant Dark fonts Also updated the settings where Dark fonts were conditionally used.
* Cleanup lint errors in `SearchContainerStyles.ts` * Fix snapshots
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 96.46% 96.45% -0.01%
==========================================
Files 109 109
Lines 3051 3048 -3
Branches 691 688 -3
==========================================
- Hits 2943 2940 -3
Misses 107 107
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kala-moz
requested changes
Mar 17, 2026
Contributor
kala-moz
left a comment
kala-moz
left a comment
There was a problem hiding this comment.
Thanks for your PR! I've added my requested changes
| @@ -3,8 +3,6 @@ import { stylesheet } from 'typestyle'; | |||
| import { FontsRaw, Spacing } from '../styles'; | |||
|
|
|||
| export const SearchContainerStyles = (mode: string, isHome: boolean) => { | |||
Contributor
There was a problem hiding this comment.
We can delete the mode parameter since we're not using it anymore. This will involve cleaning all the arguments where SearchContainerStyles is called so be sure to delete them and any unused constants:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
As part of this PR, the
fonts.tsfile has been refactored to remove the redundant Dark fonts. All fonts use the standard ligt font settings now as the dark fonts did not differ from the light fonts in any way. All places where dark fonts were being used have been updated.Fixes Bug-2022758
@kala-moz @gmierz