This repository was archived by the owner on Apr 3, 2019. It is now read-only.
feat(types): implement a serializable regex type#261
Merged
Conversation
philbooth
force-pushed
the
pb/serializable-regex
branch
2 times, most recently
from
3e47e95 to
42ee105
Compare
philbooth
force-pushed
the
pb/serializable-regex
branch
from
42ee105 to
83d46ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extraction from #258.
The configuration endpoint will have a regex property in the payload, which will also be written to Redis. Since
regex::Regexdoesn't provide implementations ofDeserializeorSerialize, we must wrap it to implement them ourselves. This change does that by just serializing the string representation of the regex.@mozilla/fxa-devs r?