Skip to content

remove deprecated logins checkpoint api#7349

Merged
FlyingBaum merged 2 commits into
mozilla:mainfrom
FlyingBaum:FXCM-2264
May 22, 2026
Merged

remove deprecated logins checkpoint api#7349
FlyingBaum merged 2 commits into
mozilla:mainfrom
FlyingBaum:FXCM-2264

Conversation

@FlyingBaum
Copy link
Copy Markdown
Contributor

@FlyingBaum FlyingBaum commented May 5, 2026

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@FlyingBaum FlyingBaum marked this pull request as draft May 5, 2026 14:05
@FlyingBaum FlyingBaum force-pushed the FXCM-2264 branch 2 times, most recently from 7b5caf8 to a84c387 Compare May 12, 2026 08:00
@FlyingBaum FlyingBaum requested a review from jo May 19, 2026 11:00
@FlyingBaum
Copy link
Copy Markdown
Contributor Author

Last week I did a mach try with my vendored changes here and there were no failures related to the removals of this PR.
However, there were several other failures from previous AS commits that have not been vendored over to m-c before. I am running another mach try here and will try finding the breaking changes.
Android and iOS are not affected by this PR.

The m-c patch is here.

@FlyingBaum FlyingBaum marked this pull request as ready for review May 19, 2026 11:01
Copy link
Copy Markdown
Contributor

@jo jo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread CHANGELOG.md Outdated
@FlyingBaum FlyingBaum force-pushed the FXCM-2264 branch 2 times, most recently from 2e9d262 to bee4f0b Compare May 22, 2026 10:08
@FlyingBaum FlyingBaum enabled auto-merge May 22, 2026 10:09
@FlyingBaum FlyingBaum added this pull request to the merge queue May 22, 2026
Merged via the queue into mozilla:main with commit 1f9c2d5 May 22, 2026
14 checks passed
@FlyingBaum FlyingBaum deleted the FXCM-2264 branch May 22, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants