Skip to content

bug(nimbus-fml): Specify dict subtypes for JsonObject in uniffi.toml #7198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
relud merged 3 commits into from
Jan 30, 2026
+2 −2
Merged

bug(nimbus-fml): Specify dict subtypes for JsonObject in uniffi.toml #7198

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60cd849
bug(nimbus-fml): Specify dict subtypes for JsonObject in uniffi.toml
relud Jan 30, 2026
f0744e4
use typing.Dict for subscripting
relud Jan 30, 2026
f471921
Apply suggestion from @bendk
relud Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/support/nimbus-fml/uniffi.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# cdylib_name = "cirrus"

[bindings.python.custom_types.JsonObject]
imports = ["json"]
imports = ["json", "typing"]
into_custom = "json.loads({})"
from_custom = "json.dumps({})"
type_name = "dict"
type_name = "typing.Dict[str, typing.Any]"
Copy link
Contributor

@bendk bendk Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to add typing to the imports list. I think this currently works because UniFFI imports typing for its own purposes, but that feels a bit fragile. Double-check me though, I could definitely be wrong about the exact config needed.

Copy link
Contributor Author

@relud relud Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it causes typing to be imported twice, but it works, and I like not depending on uniffi to implicitly import typing given that it has real potential to not be imported in the future if uniffi doesn't need it