Skip to content

Conversation

@gruberb
Copy link
Member

@gruberb gruberb commented Jan 29, 2026

Navigate to the example directory

cd examples/viaduct-cli

Test OHTTP with the NEW backend (hyper-based, async)

cargo run --release --features ohttp -- --backend new ohttp

Test OHTTP with the OLD backend (reqwest-based, sync)

cargo run --release --features ohttp -- --backend old ohttp

Add -v for verbose trace logging

cargo run --release --features ohttp -- -v --backend old ohttp

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@gruberb gruberb requested a review from bendk January 29, 2026 22:23
@gruberb gruberb force-pushed the DISCO-3930-ohttp-old-backend branch 3 times, most recently from e2d8628 to 046663a Compare January 29, 2026 23:40
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just had one, non-blocking, suggestion.

method: crate::Method,
headers: Option<HashMap<String, String>>,
body: Option<Vec<u8>>,
) -> Result<Response> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a method on Request? That would fit better with the current API IMO, but I don't want to bikeshed too much. However you want to expose the functionality is good with me.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's so much better! Thank you!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I think we would have to make Request a uniffi::Object, which would be a breaking change?

@gruberb gruberb force-pushed the DISCO-3930-ohttp-old-backend branch from 046663a to 1368d63 Compare January 30, 2026 15:05
@gruberb gruberb force-pushed the DISCO-3930-ohttp-old-backend branch from 1368d63 to d1d0b20 Compare January 30, 2026 15:24
@gruberb gruberb enabled auto-merge January 30, 2026 16:17
@gruberb gruberb added this pull request to the merge queue Jan 30, 2026
Merged via the queue into main with commit 2a2cbf7 Jan 30, 2026
14 checks passed
@gruberb gruberb deleted the DISCO-3930-ohttp-old-backend branch January 30, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants