Skip to content

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Jan 29, 2026

This is technically a breaking change that essentially enables the tracing-logging and tracing-reporting features for all consumers. However, I don't think it will matter for any consumers. The Android megazord already enabled both features. Other megazords only had the tracing-logging feature enabled, but they didn't have the error reporting code connected.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@bendk bendk requested review from a team and lougeniaC64 January 29, 2026 15:28
Copy link
Contributor

@lougeniaC64 lougeniaC64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is technically a breaking change you should add an entry to the change log.

I was going to suggest checking that these changes don't break things by using the local auto publish flow but you can't do that for iOS and I suppose we'll get an alert in the app services channel if it does anyway.

@bendk bendk force-pushed the push-szvlrsotmtqu branch from bdbad24 to 117c805 Compare January 30, 2026 14:20
This is technically a breaking change that essentially enables the
`tracing-logging` and `tracing-reporting` features for all consumers.
However, I don't think it will matter for any consumers. The Android
megazord already enabled both features. Other megazords only had the
`tracing-logging` feature enabled, but they didn't have the error
reporting code connected.
@bendk bendk enabled auto-merge January 30, 2026 14:20
@bendk bendk added this pull request to the merge queue Jan 30, 2026
Merged via the queue into mozilla:main with commit b85d2cd Jan 30, 2026
14 checks passed
@bendk bendk deleted the push-szvlrsotmtqu branch January 30, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants