fix: update user_collection_quota#2328
Draft
taddes wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates to simplified upsert in SpannerDb::update_user_collection_quotas
Metric note:
Moved the
storage.quota.update_existing_totalsinto theifexpr. I looked intoMetrics::start_timerand found that because the .clone() produces an unbound temporary, the drop op runs at the end of the statement, so the "timer" records ~0 ms and is effectively a counter, not a duration. The change is therefore a reduction in count volume equal to the rate of quota disabled calls. The label is storage.quota.* and firing it where no quota work happens seemed misleading.Issue(s)
Closes STOR-564.