Bug 1562731 - upgrade to Python-3 - #246
Merged
Merged
Conversation
escapewindow
approved these changes
Nov 13, 2019
Contributor
Author
|
Nothing flask-y changed here, so I think it's OK. I'll check the travis failures. |
Contributor
|
I checked the travis failures for you. :) |
This was referenced Nov 14, 2019
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only laggard dependency was flask_secure_headers, which appears unmaintained. It's just setting headers, though, so not too complicated. I vendored tarek's version from twaldear/flask-secure-headers#9. He had finished the meat of it (really just removing some useless try/except's and fixing whitespace) and was working on the tests.
The tests pass locally. I bet they'll pass in CI. But I have less confidence this will work right-off in a deployment. We should probably figure out a plan to deploy "safely":
Anyway, I'd like to get @escapewindow to have a look at this first, then we can work on landing it.