Bug 2039562: Fix initial state flicker.#264
Open
pollym wants to merge 2 commits into
Open
Conversation
Also added some ui tests around the new game screen. The flicker is handled by alpha-ing out the components if they're null & it's not currently possible through the compose test apis to make assertions about the alpha state, so that part was verified visually, but we can check that the other behaviours of ui components are wired up as expected. Did a small refactor around this to hoist state and expose smaller more testable params to NewGameScreen.
Contributor
|
View this pull request in Lando to land it once approved. |
![mozilla-code-review[bot]](https://avatars.githubusercontent.com/in/3631945?s=60&v=4){kind=small}
| # file, You can obtain one at http://mozilla.org/MPL/2.0/. | ||
| # | ||
|
|
||
| sdk=35 No newline at end of file |
There was a problem hiding this comment.
File does not end with newline character
here is a new line
Contributor
Author
mozilla-code-review
Bot
dismissed stale reviews from themself
This review is now deprecated.
|
man this browser is going down hill fast |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added some ui tests around the new game screen. The flicker is handled by alpha-ing out the components if they're null & it's not currently possible through the compose test apis to make assertions about the alpha state, so that part was verified visually, but we can check that the other behaviours of ui components are wired up as expected. Did a small refactor around this to hoist state and expose smaller more testable params to NewGameScreen.