Bug 2036474 - Updated s2s telemetry#249
Closed
fmasalha wants to merge 1 commit into
Closed
Conversation
Contributor
|
View this pull request in Lando to land it once approved. |
segunfamisa
reviewed
May 8, 2026
| override val info = LlmProvider.Info( | ||
| nameRes = R.string.mlpa_llm_provider_name, | ||
| iconRes = R.drawable.firefox_icon, | ||
| model = ModelID.mozSummarization.value, |
Contributor
There was a problem hiding this comment.
I think that if we have a future where we have multiple model id's, or a dynamic model id, this would break.
If I remember correctly, we have the model id as part of the request.......so I don't know if it is "static". I believe it could be dynamic, so far...based on the design we have.
Contributor
There was a problem hiding this comment.
I believe that we have a fixed value we define here -
Is there a way we could pass the model from the llmProvider to the Llm Request? So that we are certain that the correct model owned by the provider is the same one used for the prompt request
3db09e7 to
d0614b8
Compare
Contributor
|
Since this is a telemetry patch let's move it to phabricator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.