Skip to content

Bug 2036474 - Updated s2s telemetry#249

Closed
fmasalha wants to merge 1 commit into
mozilla-firefox:autolandfrom
fmasalha:s2s-telemetry-fixes-v2
Closed

Bug 2036474 - Updated s2s telemetry#249
fmasalha wants to merge 1 commit into
mozilla-firefox:autolandfrom
fmasalha:s2s-telemetry-fixes-v2

Conversation

@fmasalha
Copy link
Copy Markdown
Contributor

@fmasalha fmasalha commented May 8, 2026

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

View this pull request in Lando to land it once approved.

override val info = LlmProvider.Info(
nameRes = R.string.mlpa_llm_provider_name,
iconRes = R.drawable.firefox_icon,
model = ModelID.mozSummarization.value,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if we have a future where we have multiple model id's, or a dynamic model id, this would break.

If I remember correctly, we have the model id as part of the request.......so I don't know if it is "static". I believe it could be dynamic, so far...based on the design we have.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we have a fixed value we define here -

internal val Prompt.asRequest
get() = Request(
model = ModelID.mozSummarization,
messages = buildList {
systemPrompt?.let { add(Message.system(it)) }
add(Message.user(userPrompt))
},
stream = true,
)

Is there a way we could pass the model from the llmProvider to the Llm Request? So that we are certain that the correct model owned by the provider is the same one used for the prompt request

@fmasalha fmasalha force-pushed the s2s-telemetry-fixes-v2 branch from 3db09e7 to d0614b8 Compare May 12, 2026 12:40
@fmasalha fmasalha requested a review from segunfamisa May 12, 2026 13:25
@boek
Copy link
Copy Markdown
Contributor

boek commented May 12, 2026

Since this is a telemetry patch let's move it to phabricator

@boek boek closed this May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants