Bug 2007071 - Align MIDI errors with the web-midi-api spec#14
Closed
nikelborm wants to merge 1 commit into
Closed
Conversation
…d `SecurityError` and `InvalidAccessError` in favor of `NotAllowedError` r?gsvelto,bholley = `InvalidAccessError` replaced by `NotAllowedError`: The change in spec: [WebAudio/web-midi-api@3795f22](WebAudio/web-midi-api@3795f22) According PR: [WebAudio/web-midi-api#278](WebAudio/web-midi-api#278) MDN update PR: [mdn/content#42334](mdn/content#42334) == Affected APIs 1. `.send` method of output MIDI ports 2. `.open` method of MIDI ports = `SecurityError` replaced by `NotAllowedError`: The change in spec: [WebAudio/web-midi-api@b7806b8](WebAudio/web-midi-api@b7806b8) According PR: [WebAudio/web-midi-api#267](WebAudio/web-midi-api#267) MDN update PR: [mdn/content#41956](mdn/content#41956) == Affected APIs 1. `navigator.requestMIDIAccess` method
Contributor
|
(Automated Close) Please do not file pull requests here, see https://firefox-source-docs.mozilla.org/contributing/how_to_submit_a_patch.html |
feder-cr
pushed a commit
to feder-cr/invisible-firefox
that referenced
this pull request
May 20, 2026
…ad (fixes mozilla-firefox#14) scripts/make_release.sh was previously running `tar -czf firefox` directly against obj-*/dist/bin/firefox — preserving the ~6,900 symlinks that the in-tree build scatters across the source tree. The published Linux tarballs for firefox-3 and firefox-4 were dangling-symlink graveyards that could not boot Firefox; 265 downloads were affected. This replaces the broken script with a pipeline that: 1. linux_release.sh — runs `cp -aL` (dereference), strips debug, scrubs `/home/feder` build-host paths, removes dev-only binaries (xpcshell/certutil/pk12util/rapl that leaked build paths), and produces a tarball with anonymized owner + fixed mtime. 2. validate_release.py — extracts BOTH archives to clean temp dirs and verifies: 0 symlinks, 0 path-style leaks (/home/feder, Users\Feder), critical files present (firefox, application.ini, dependentlibs.list), and `firefox --version` actually runs. Linux smoke runs through WSL when invoked from Windows. Exits non-zero on any failure. 3. make_release.sh — drives both, then refuses to upload if the validator rejects either archive. The validator step is mandatory, not advisory: this is the gate that was missing. Confirmed locally: - validator against the broken firefox-4 tarball -> exit 1 (6897 symlinks) - validator against the rebuilt firefox-4 tarball -> exit 0 (firefox 150.0.1 runs) The firefox-4 and firefox-3 release assets on feder-cr/invisible_playwright have already been replaced with the rebuilt content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecated
SecurityErrorandInvalidAccessErrorin favor ofNotAllowedError.InvalidAccessErrorreplaced byNotAllowedError:The change in spec: WebAudio/web-midi-api@3795f22
According PR: WebAudio/web-midi-api#278
MDN update PR: mdn/content#42334
Affected APIs
.sendmethod of output MIDI ports.openmethod of MIDI portsSecurityErrorreplaced byNotAllowedError:The change in spec: WebAudio/web-midi-api@b7806b8
According PR: WebAudio/web-midi-api#267
MDN update PR: mdn/content#41956
Affected APIs
navigator.requestMIDIAccessmethod