Repository navigation
Pin the base image and fix runtime user creation - #16
Merged
Merged
Conversation
The build stopped working without a commit touching it: `condaforge/miniforge3:latest` moved on to a base that ships neither `addgroup` nor `adduser`, so `RUN addgroup --system ... && adduser --system ...` failed and no release image could be published. Switch to `groupadd`/`useradd`, which the image does provide, and pin the base tag in both the runtime and the test image so it cannot drift again. `--create-home` keeps the writable HOME that `adduser --system` used to provide and that conda needs while creating the environment. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The image build stopped working without any commit touching it.
condaforge/miniforge3:latestmoved on to Ubuntu 24.04.4, which ships neither
addgroupnoradduser, so this line failed:That is the
build-deployjob — the one that publishes the release image to ghcr — so while itfails, tagging a release produces nothing.
What this changes
groupadd/useraddinstead ofaddgroup/adduser; the image does provide those.--create-homekeeps the writable HOME that
adduser --systemused to create. That part matters:conda env createalready runs asmoveappsrather than root, and conda needs a writable HOME for itscaches.
26.3.2-3in both the runtime and the test image, so it cannot driftagain. That tag is the same digest
latestcurrently resolves to (sha256:70ce3950…), so thispins the present state rather than moving to a different one.
Verified locally (arm64): the runtime image builds, and in it the user is
uid=999(moveapps) gid=999(moveapps)with a writable/home/moveappsand the conda environment in place. Starting theimage runs
main.pyout of/opt/cargo-agent-python/conda, so the entrypoint is intact. The testimage builds and runs its suite —
Ran 4 tests in 0.053s / OK. CI additionally covers amd64.