Repository navigation
Add inch output for three-axis mill posts - #155
Merged
mountainarcwelding merged 2 commits intoNov 10, 2026
Merged
mountainarcwelding merged 2 commits into
mountainarcwelding merged 2 commits into
Conversation
Keep G53 audit locals with the inch feed-mode snapshot. Add an Unreleased Added changelog entry for three-axis inch (G20) output. Co-authored-by: DarkBiscuits <darkbiscuitstuff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom posts currently accept only millimetres, and read-back and auditing reject G20. Add
"units": "inch"for three-axis mill/router posts while keeping the IR and physical tolerances in millimetres.The writer converts linear coordinates, arc centres/radii, probe targets, and feeds to inches. Read-back and the mill auditor normalize them to mm and mm/min; the audit retains the actual unit declaration. Arc-rounding guards and feed comparisons account for the output precision. Spindle speeds, dwell times, identifiers, and digital pins are unchanged.
Require G20 before dimensional words and reject conflicting units or unit switches. Literal post-template numbers remain in the declared output units, with documentation explaining how to adapt a metric post. Rotary, five-axis, and lathe inch configurations remain explicitly unsupported. Existing built-in posts stay metric; this adds neither a new controller post nor a CLI units override.
Validation on Linux with Rust 1.95:
scripts/check.shpassed: formatting, workspace Clippy, 1,102 passing tests (one existing ignored), wasm library checks, and licenses.Related to #88.
DarkBiscuits, co-authored with Codex. Implementation and tests use CAMpanion's own sources and synthetic inputs, following the clean-room contribution rules. No physical controller testing was performed.