Repository navigation
Preserve tool shapes in IR and verify each move with its cutter - #154
Merged
mountainarcwelding merged 2 commits intoNov 10, 2026
Conversation
Owner
Keep both Unreleased changelog entries: tool-shape Added notes and the G91.1/G53 Fixed notes. Co-authored-by: DarkBiscuits <darkbiscuitstuff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runcurrently drops cutter shape from the IR, soverify --meshrequires a separate--tooland applies that single cutter to the whole program.Preserve optional flat, ball, bull and V-bit geometry on IR tools, and let
verify --meshselect the cutter for each cutting move. Tool changes within a path are honored.--toolremains a global override and is identified in the diagnostic output. Existing IR without shape metadata still loads; mesh verification of its cuts requires an override.Chamfer operations keep their existing V-bit fields and copy their geometry onto the tool. Conflicting angles or tip diameters for one tool ID, or an explicit tool shape conflicting with chamfer geometry, fail before output is written. V-bit metadata is supported; V-bit mesh verification explicitly returns “not supported yet” instead of skipping cuts or substituting another shape.
Validation on Linux with Rust 1.95:
--tool; the chamfer example emits V-bit metadata.scripts/check.shpassed: formatting, workspace Clippy, 1,103 passing tests (one existing ignored), wasm library checks, and licenses.Fixes #146.
DarkBiscuits, co-authored with Codex. Implementation and tests use CAMpanion's own sources and synthetic inputs, following the clean-room contribution rules. No physical controller testing was performed.