Add a "fill to zero" option for area charts.#583
Open
AHilyard wants to merge 3 commits intomorrisjs:masterfrom
AHilyard:master
Open
Add a "fill to zero" option for area charts.#583AHilyard wants to merge 3 commits intomorrisjs:masterfrom AHilyard:master
AHilyard wants to merge 3 commits intomorrisjs:masterfrom
AHilyard:master
Conversation
Setting the fill to zero option will cause an area chart with negative values to only fill to the zero line, instead of the bottom of the chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when creating an area chart that contains negative values, the chart is filled to the bottom, potentially misrepresenting the actual data. The fillToZero option allows the chart to fill only between the line and zero, where ever that may lie.
See this jsbin for an illustration: http://jsbin.com/qahijimebo/1/edit?html,js,output