[blue rolling fallback] liquidation precision - #1169
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 63f09399bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
peyha
changed the title
peyha
changed the title
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3124b4f60a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Adrien Husson <adhusson@gmail.com> Signed-off-by: PA <50184410+peyha@users.noreply.github.com>
| /// which case the destination position debt and collateral can be difficult to predict. | ||
| /// @dev Contrary to Midnight, Blue positions can be liquidated because of interest accrual, which should be taken into | ||
| /// account when deciding/approving the rolling configuration. | ||
| /// @dev Partial rolls of unhealthy Midnight positions fail, except if rounding makes the remaining position healthy. |
There was a problem hiding this comment.
| /// @dev Partial rolls of unhealthy Midnight positions fail, except if rounding makes the remaining position healthy. | |
| /// @dev Partial rolls leaving the Midnight position unhealthy fail. |
There was a problem hiding this comment.
but if the position is healthy it cannot be made unhealthy through partial rolling right?
There was a problem hiding this comment.
i think both can happen:
- if the position starts unhealthy, rounding down the removed collateral can make it healthy
- if the position starts healthy, rounding down in the max debt loop can make it unhealthy
There was a problem hiding this comment.
yes, pushing some tests to show that
Signed-off-by: MathisGD <74971347+MathisGD@users.noreply.github.com>
5 participants
No description provided.