[tests] fix failing tests on main - #268
Draft
claude[bot] wants to merge 5 commits into
Draft
Conversation
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019gs1pEEFznxWqLUTa2aNVJ
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019gs1pEEFznxWqLUTa2aNVJ
GitHub keeps only ~10 failure annotations per step; on the chain-1 job that cap dropped the "Failing tests:" summary, which is the single most informative annotation. Emit it first and cap the individual [FAIL lines at 4. The --no-isolate probe already ruled out forge 1.8's isolate default, so also disable its other new default, dynamic test linking. Report the probe through notices, which have their own annotation budget and so cannot evict the errors above. Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019gs1pEEFznxWqLUTa2aNVJ
Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019gs1pEEFznxWqLUTa2aNVJ
Emit the isolate / dynamic_test_linking values forge actually resolves, so we can tell whether foundry.toml is honoured at all, and re-run each of the two new forge 1.8 defaults separately instead of both at once, so a failure can be attributed to one of them. Also emit the "Encountered a total of ..." line as its own annotation: GitHub truncates each annotation at ~4096 bytes and the totals line at the end of a long "Failing tests:" block was being cut off. Co-authored-by: MathisGD <74971347+MathisGD@users.noreply.github.com> Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019gs1pEEFznxWqLUTa2aNVJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathis GD · Slack thread
The Foundry test jobs on
mainare red under forge 1.8.1, with no repo-side change. Forge 1.8's dynamic test linking default breaksvm.mockFunction, which the twoBundler3LocalTestprotected-call tests rely on, so it is disabled.The remaining failures are fork migration tests hitting current chain state (Aave V2 reserves frozen, Compound V2 minting paused), and are not addressed here.
Generated by Claude Code