Skip to content

use latest block - #235

Merged
MathisGD merged 4 commits into
mainfrom
test/latest-block
Sep 1, 2026
Merged

use latest block#235
MathisGD merged 4 commits into
mainfrom
test/latest-block

Conversation

@adhusson

@adhusson adhusson commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

must fix failing tests on ethereum first

MathisGD
MathisGD previously approved these changes Jan 30, 2025
Base automatically changed from fix/restrict-receiver-on-deposit to main February 3, 2025 10:31
@adhusson
adhusson dismissed MathisGD’s stale review February 3, 2025 10:31

The base branch was changed.

@MathisGD

Copy link
Copy Markdown
Contributor

for MA3, we can simply keep the same block, as it is now being deprecated

@adhusson

adhusson commented Feb 11, 2025

Copy link
Copy Markdown
Contributor Author

Tests pass, but I saw some transient failures on the following tests. I could not find which block number it was.

[FAIL: revert: TRANSFER_FROM_FAILED] testMigrateBorrowerDaiToSDaiWithPermit2() (gas: 7432427)
[FAIL: revert: TRANSFER_FROM_FAILED] testMigrateBorrowerWithPermit2() (gas: 5737762)
[FAIL: revert: TRANSFER_FROM_FAILED] testMigrateStEthPositionWithPermit2() (gas: 7151044)

@MathisGD
MathisGD marked this pull request as ready for review July 31, 2026 10:24
@MathisGD MathisGD self-assigned this Jul 31, 2026
@MathisGD
MathisGD requested a review from QGarchery September 1, 2026 10:05
@MathisGD
MathisGD merged commit 467dec8 into main Sep 1, 2026
1 check passed
@MathisGD
MathisGD deleted the test/latest-block branch September 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants