Repository navigation
fix(desktop): preserve own JSON keys in task grading - #10331
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
[Medium impact] The PR appears safe to merge; no blocking issue was found. SummaryThis PR preserves own JSON keys such as
No new actionable issues were found. The previous unnumbered finding is fixed: both failure guards now throw the parser's actual error. Tests were not rerun during this review. The live supersession check was blocked by missing GitHub authentication; no replacement PR was established. Reviews (3) · Last reviewed commit: "fix(desktop): retain own column keys in ..." · Reviewed by Greptile |
Summary
Fixes #10330. Desktop task grading discarded own JSON members named
__proto__at two admission boundaries:file_absent; malformed views under that path were silently ignored.{id:1,"__proto__":"wanted"}became{id:1}, so a nonmatching row could passrow_present. A predicate containing only that column was rejected as empty.Use the existing
jsonRecordSchemafor state files and row conditions. Normalize optional file errors at their owner and remove the redundant downstream projection. Exact keys, nested values, column validation and the nonempty-predicate rule are preserved. The evaluator, draft producer and exported Python verifier already iterate the owned entries; no downstream repair or new abstraction is needed.Verification
Executed on macOS arm64 with Node 24.22.1/npm 11.16.0, after merging main
bbe2bcc979:npm run check— passed; typed lint: 0 errors, 4,987 advisory warnings.npm run docs:check— passed, including 9 documentation consistency tests.npm run verify:test-discovery— all 3,507 files discovered exactly once.npm run check:fastandgit diff --check— passed.The first broader run selected Apple's Python 3.9 and had nine verifier failures because that interpreter lacks
BaseException.add_note. Repeating it with the existing Python 3.15.2 passed all 174 tests in that run. The additional 42-test run also passed.Hosted CI on
23d4ecc977fe29e4a7c73e80a917b8ff9ec69b2fpassed, including all four required checks, source tests and all eight built-test shards. The computer and protocol are source-owned stand-ins; installed AgentEnv, a real desktop application, other hosts and natural special-name prevalence remain unverified. No performance claim is made.Scope and coordination
Ordinary correctness fix within existing JSON admission contracts; no new authority, provider, execution, setup or advertised schema. Extra wire metadata remains accepted. The sibling audit groups both confirmed losses in this PR. The latest inventory of 874 open PRs has no competing condition-parser change; #9292 adds an unrelated output-admission test in the shared MCP test file. No related cleanup remains in these owners.
Author readiness
Human owner: @kaoru0822-kitauji. This author is exempt from the declaration under CONTRIBUTING.md; no human review is attested here.