Repository navigation
[pull] master from home-assistant:master - #414
Merged
Merged
Conversation
* speech_to_phrase: Shut down cleanly on stop speech-to-phrase has no SIGTERM handler, so s6's default SIGTERM kills the process and the container exits with code 143, which newer Supervisor versions flag as an unclean shutdown. It does catch KeyboardInterrupt and exit 0 on SIGINT, so tell s6 to stop the service with SIGINT via the down-signal file. Verified with the full s6 init: docker stop completes in ~3s, the service log shows a clean stop, and the container exits with code 0. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * speech_to_phrase: Probe readiness every 5s during startup With the default 30s healthcheck interval the app can sit in the "Starting" state for half a minute after it is already serving. Use --start-interval=5s so readiness is detected within seconds once training completes and the Wyoming port opens. Verified: container reports healthy 8s after start (including forced training), down from up to ~40s. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Jan Čermák <sairon@users.noreply.github.com>
* whisper: Shut down cleanly on stop wyoming-faster-whisper has no SIGTERM handler, so s6's default SIGTERM kills the process and the container exits with code 143, which newer Supervisor versions flag as an unclean shutdown. It does catch KeyboardInterrupt and exit 0 on SIGINT, so tell s6 to stop the service with SIGINT via the down-signal file. Same fix as speech_to_phrase; mechanism verified there with the full s6 init (docker stop ~3s, container exit code 0). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * whisper: Probe readiness every 5s during startup With the default 30s healthcheck interval the app can sit in the "Starting" state for half a minute after it is already serving. Use --start-interval=5s so readiness is detected within seconds once the model is loaded and the Wyoming port opens. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Jan Čermák <sairon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )