Repository navigation
feat: open owned child windows from the host - #25
Open
moonolgerd wants to merge 1 commit into
Open
moonolgerd wants to merge 1 commit into
moonolgerd wants to merge 1 commit into
Conversation
window.open and window.openChild stay on the caller's origin, connect as a new FDC3 instance of the parent's app, and close with the window that owns them. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.openis handled with a WebView2NewWindowRequesteddeferral, so the return value andwindow.openerare the owned child.window.openChild({ url, width, height })opens a window owned by the caller at the requested outer size.{ error }. The child connects to FDC3 as a new instance of the parent's appId and closes when the owner closes.OpenChildRequestandwindow.openChildwere added to the IPC contract. The TypeScript types were regenerated by Bermuda.IpcContract.SourceGenerator.Test plan
dotnet testIpcDispatchTests: 12 passedwindow.opencan callwindow.close(), butchrome.webview.hostObjectscalls from that page never reach the host.openChildwindows do not have that problem. Hiding the main window to the tray does not close owned children; they close when the owner actually closes.Closes #19
Made with Cursor