Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@wordpress/url": "file:../url",
"classnames": "^2.2.5",
"clipboard": "^2.0.1",
"diff": "^3.5.0",
"diff": "^8.0.3",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update lockfile so diff actually upgrades

Changing packages/components/package.json alone doesn’t update the resolved version in package-lock.json, which still pins diff to 3.5.0. Any install that uses the lockfile (e.g. npm ci in CI or contributors) will continue to pull 3.5.0 and the ReDoS fix won’t be applied, so the security upgrade is effectively skipped in those environments. The lockfile needs to be updated alongside this dependency bump to make the upgrade take effect.

Useful? React with 👍 / 👎.

"dom-scroll-into-view": "^1.2.1",
"lodash": "^4.17.10",
"memize": "^1.0.5",
Expand Down