Conversation
3 tasks
|
Reporter of #472 here — verified the hook wiring: both Antigravity ensure hooks now call the managed bootstrap on the cold path (table on #472). Two review notes:
Also: the branch is based on v0.1.59; |
ZacLou
force-pushed
the
fix-antigravity-ensure-auto-update-472
branch
from
September 4, 2026 05:00
3a568b5 to
3366349
Compare
Author
|
Thanks for the careful review @NyxSpecter4 — all three points addressed in 3366349:
Happy to iterate further if anything else looks off. |
ZacLou
force-pushed
the
fix-antigravity-ensure-auto-update-472
branch
from
September 5, 2026 07:43
3366349 to
2cc7ae5
Compare
ZacLou
marked this pull request as draft
September 6, 2026 02:30
… hooks (monk-io#472) The Antigravity PreInvocation hooks (.antigravity-plugin/hooks/ensure-monk-agent.{sh,ps1}) were cold-starting whatever monk-agent binary already existed on disk without ever calling the managed bootstrap (scripts/ensure-monk-agent.{sh,ps1}). After a plugin upgrade, Antigravity users could keep running a stale monk-agent indefinitely. Changes: - .antigravity-plugin/hooks/ensure-monk-agent.sh now invokes the sibling bootstrap script on cold start and uses its stdout (the resolved binary path) as the agent to start. stderr is suppressed to keep the hook stdout JSON-clean. - .antigravity-plugin/hooks/ensure-monk-agent.ps1 does the same, calling the bootstrap with -Quiet and redirecting non-output streams to $null. - .antigravity-plugin/scripts/ensure-monk-agent.ps1 gains a -Quiet switch that suppresses the Write-Host 'Installing...' message so the hook only receives the binary path on stdout. - Added regression tests verifying the hooks reference the bootstrap and that the bootstrap supports the -Quiet contract. Fixes monk-io#472.
ZacLou
force-pushed
the
fix-antigravity-ensure-auto-update-472
branch
from
September 16, 2026 10:03
2cc7ae5 to
df93641
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #472
The Antigravity PreInvocation ensure hooks now call the managed bootstrap script (scripts/ensure-monk-agent.{sh,ps1}) on cold start, so a plugin upgrade refreshes monk-agent automatically instead of perpetually restarting the existing stale binary.