fix: only nudge on explicit signed-out auth state - #374
Open
paulcakeface wants to merge 1 commit into
Open
paulcakeface wants to merge 1 commit into
paulcakeface wants to merge 1 commit into
Conversation
Author
|
Bounty-deadline review nudge: this remains current against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #364.
The POSIX launcher previously treated every non-empty
/auth.jsonbody that was notsignedIn:trueas a confirmed signed-out state. That meant malformed, partial, or unrelated auth responses emitted the SessionStart sign-in warning and posted the sign-in nudge.This change makes the shell path tri-state:
signedIn:true-> quietsignedIn:false-> nudgeRegression coverage is added to the existing
start-monk-agent-fastpath.shtest, which is already run by the repository's Ubuntu/macOS Install E2E job. The fixture exercises malformed, unrelated, explicit-false, and explicit-true payloads, and the test also asserts the three shipped POSIX launcher copies remain byte-identical.Local validation:
./tests/start-monk-agent-fastpath.sh✅./tests/start-monk-agent-readiness-timeout.sh✅./tests/start-monk-agent-antigravity-python-path.sh✅sh -non all three POSIX launcher copies ✅cmpchecks ✅git diff --check✅Prepared with ChatGPT/Codex assistance.