feat(devtools-connect): enable driver network check during connect COMPASS-9455#628
Open
feat(devtools-connect): enable driver network check during connect COMPASS-9455#628
Conversation
Collaborator
Author
|
Depended on by: mongodb-js/compass#7897 |
Open
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously #557 we disabled the driver's ping since compass did its own. Now the driver has removed its ping BUT has changed the condition to run an ismaster and return the healthy connection to the pool. This means loadBalancers without creds will throw network errors.
Now we let the driver do this "ping" again, (its the handshake only) and we'll be able to remove compass' ping saving an RTT. big for DE.
Open Questions
Checklist