chore(compass-user-data): remove old cluster-connection subdomain references COMPASS-10553

[nbbeeken]

Description

Just removing this so we don't get mixed up when looking for usages since we're going to repurpose the subdomain

Checklist

• New tests and/or benchmarks are included
• Documentation is changed or added
• If this change updates the UI, screenshots/videos are added and a design review is requested
• If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
• I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

• Bugfix
• New feature
• Dependency update
• Misc

Open Questions

Dependents

Types of changes

• Backport Needed
• Patch (non-breaking change which fixes an issue)
• Minor (non-breaking change which adds functionality)
• Major (fix or feature that would cause existing functionality to change)

[Copilot]

Pull request overview

This PR updates the compass-user-data test suite to remove legacy cluster-connection.cloud.mongodb.com subdomain references, reducing confusion when searching for or repurposing that subdomain elsewhere in the codebase.

Changes:

• Replaced cluster-connection.cloud.mongodb.com/... with cloud.mongodb.com/... in AtlasUserData unit test stubs and assertions.
• Minor formatting simplifications for a few .returns(...) calls while updating the strings.

[johnjackweir]

what happens if someone hits the old URL?