Fix the bulk-delete button collapsing to icon-only - #86
Open
alvst wants to merge 1 commit into
Open
Conversation
Missing .fixedSize() let the tight top-bar HStack compress the button down to its icon, dropping the "Delete N" text entirely — the same bug just found and fixed on the new Undo button, which already had the fix applied. This one predates tonight's changes; it's in already-merged upstream code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Delete N" button in the top bar was losing its label. A missing
.fixedSize()let the tight top-barHStackcompress it down to just the icon, so the count — the part that tells you how much you're about to destroy — disappeared.What changed
.fixedSize(), so it keeps its "Delete N" text instead of being squeezed to its icon.Screenshots
Before:
After:
Notes for review
This feature should be bundled into v2.
Part of #80.