Skip git run on target and fill revision correctly#17
Closed
agavrik wants to merge 4 commits into
Closed
Conversation
target and fill current_revision locally just after checkout
target and fill current_revision locally just after checkout
Conflicts: lib/capistrano/rsync.rb
|
+1 |
1 similar comment
|
+1 |
Author
|
In fact, I think that was the wrong way of doing it (at least if you only need git). You just need to set :scm to :rsync in deploy.rb. And take some other fixes in pull-requests around. So I based on https://github.com/STRML/capistrano-rsync and added support for passing server port to rsync and updated README into https://github.com/agavrik/capistrano-rsync. It is pull-requested to STRML as well. |
Author
|
So I just closed this pull request as now this PR has my changes as well - #13 |
ezekg
pushed a commit
to ezekg/capistrano-rsync
that referenced
this pull request
Jan 4, 2016
Don't return nil if revision is already clean
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue description: capistrano 3 tries to run git on target for git:check and git:create_release (which fails since there may be no access to local repo from target system). Also revision version is not passed to target system.
Root cause: Without Rake::Task.clear new task definition is not replacing, but appending new functionality.
Solution: Added clear of git:check, git:create_release and git:set_revision. Fill current_revision capistrano variable after cloning locally