Skip to content

fix: align pisp v2 api specification with pisp sig documentation - #232

Open
HtetShwe wants to merge 7 commits into
mojaloop:mainfrom
HtetShwe:fix/4505-align-pisp-v2-api-specification-with-pisp-sig-doc
Open

HtetShwe wants to merge 7 commits into
mojaloop:mainfrom
HtetShwe:fix/4505-align-pisp-v2-api-specification-with-pisp-sig-doc

Conversation

@HtetShwe

Copy link
Copy Markdown
Contributor

Summary

Addresses mojaloop/project#4505.

This PR aligns the PISP v2.0 API snippets with the PISP-SIG v2.0 design document for the audited account-linking discrepancies.

Changes

  • Add missing GET /tppAccounts/{accountRequestId}/{SignedChallenge} endpoint.
  • Rename tppAccounts callback path parameter from {ID} to {accountRequestId}.
  • Align PISP account request schema field names:
    • partyItentifier -> partyIdInfo
    • authChannel -> authChannels
    • accounts -> accountList
  • Add reusable accountRequestId and SignedChallenge path parameters.
  • Rebuild generated PISP/admin OpenAPI artifacts.

Validation

  • npm test passes locally.

  • Screenshot 2026-08-13 at 4 56 35 PM
  • Rebuilt with :

    • docs/thirdparty-admin-v2.0-openapi3-snippets.yaml
    • thirdparty/v2_0/openapi3/thirdparty-pisp-admin-api.yaml

Notes

  • The known singular/plural naming inconsistency around /tppAccountRequest vs /tppAccountsRequest is left unchanged as it is explicitly out of scope in the issue.

@CLAassistant

CLAassistant commented Aug 13, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@HtetShwe
HtetShwe force-pushed the fix/4505-align-pisp-v2-api-specification-with-pisp-sig-doc branch from 21b1221 to c585149 Compare September 18, 2026 14:36
@sonarqubecloud

Copy link
Copy Markdown

@HtetShwe
HtetShwe marked this pull request as ready for review September 18, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants