Conversation
HtetShwe
force-pushed
the
fix/4505-align-pisp-v2-api-specification-with-pisp-sig-doc
branch
from
September 18, 2026 14:36
21b1221 to
c585149
Compare
|
HtetShwe
marked this pull request as ready for review
September 18, 2026 16:09
HtetShwe
requested review from
elnyry-sam-k,
gibaros,
kleyow,
shashi165 and
vijayg10
as code owners
September 18, 2026 16:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Addresses mojaloop/project#4505.
This PR aligns the PISP v2.0 API snippets with the PISP-SIG v2.0 design document for the audited account-linking discrepancies.
Changes
GET /tppAccounts/{accountRequestId}/{SignedChallenge}endpoint.tppAccountscallback path parameter from{ID}to{accountRequestId}.partyItentifier->partyIdInfoauthChannel->authChannelsaccounts->accountListaccountRequestIdandSignedChallengepath parameters.Validation
npm testpasses locally.Rebuilt with :
docs/thirdparty-admin-v2.0-openapi3-snippets.yamlthirdparty/v2_0/openapi3/thirdparty-pisp-admin-api.yamlNotes
/tppAccountRequestvs/tppAccountsRequestis left unchanged as it is explicitly out of scope in the issue.