Merged
Conversation
- Substitute repetitive push_backs with initializer list to make tests simpler and easier to read - Create tests for edge cases when using ++ and -- on empty list - Make the tests pass by modifying the list iterator code
- Dereferencing end iterator - Dereferencing begin iterator on empty list - Post and pre decrement operator functionality
- Create tests for dereferencing and copying iterators - Create tests for edge cases when incrementing or decrementing out of range - Simplify tests by using initializer lists and constructors using iterators
- Move private fields to the end - Move private internal methods below public ones - Make empty() rely on head ptr - Make clear() rely on empty() - Use empty() to express intent when checked
…ptions in empty list
- Create tests for using pre-decrement (--iterator) on begin iterator in both empty & non-empty lists - Make the tests pass by adding a check to raise exception if it's called on begin iterator
- Create tests for erase functionality in map - Create DestructionFlag to flag calling destructor on values when entries are erased - Add a destruction flag test for clear method as well
…to pass the tests
Owner
Author
|
looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release new features and refactor code for simplicity and readability
New features
move_to_backmethod on map: allows moving entries to the end of the map in O(1) without copying the value--itandit--)clearandemptymethods in mapAll features were developed with TDD
Refactor