Use event's ObjectManager instead of injected EntityManager in DoctrineEncryptListener#68
Merged
mogilvie merged 3 commits intomogilvie:masterfrom Feb 19, 2026
Conversation
…n DoctrineEncryptListener
Contributor
Author
|
Hey @mogilvie, do you have some time to look at this PR ? |
Move deprecation from constructor to doc block for compatibility with other php and symfony versions.
Owner
|
Thanks for your contribution @jdecool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DoctrineEncryptListener is currently using the default injected EntityManager. This caused errors when working with entities coming from another EntityManager of the default one (for example, we use this bundle in a modular monolith application, where each module is managed by its own EntityManager).
This PR refactors the DoctrineEncryptListener to use the ObjectManager from the event arguments instead of the injected EntityManager instance. So it will use the EntityManager related to the processing entity.