Repository navigation
Conversation
It is the base that the sdk-streams port changes. Its tree equals that branch's head.
The stream runtime now lives in the sdk-streams crate. STREAMS_STORE picks Redis or memory, and the tests default to memory on the time-skipping server.
Brook names the producers stream_producer and the client handle stream_handle. It has no stream notifier, so STREAMS_NOTIFY is gone.
2 of 3 tasks
2 of 3 tasks
Owner
Author
|
Replaced by #6, the Brook v3 stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR ports the harness onto Brook, the sdk-python build at
moe/brook/v2/h10-sdk-streams. It replaces #3, which pinned the Bridge builddr40.temporaliois pinned to h1060c15016, anduv.lockfollows. The agent publishes withstream_producer(TURN_EVENTS)and a syncappend. Activities publish throughstream_producertoo, withawait append. Clients, the web app, the subagent activities and the NexuspollMessageshandler read withstream_handle(client, ...). Brook has no stream notifier, soSTREAMS_NOTIFYand thenotify_on_append()call are gone, and the README says a stock dev server is enough. The branch starts at #3's head, so its commits stay in the history. The last commit removes two unused imports.Why?
Brook is the interim release. The harness reads only from outside Workflows, so it needs no Workflow reads, Wakes or notifier, and Brook covers what it uses.
How did you test it?
Link to a test plan if any -